[Lldb-commits] [PATCH] D76470: [lldb/Target] Rework the way the inferior environment is created

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

I think this is a good change, and is in line with what we have discussed previously. I have just one question about the exact variable interactions here.

Since the raison d'être of the new setting is to be able to "un-inherit" a particular environment variable, I'm wondering if it should only take effect if `inherit-env` is true (as otherwise you can achieve the same effect by deleting stuff from env-vars)? So instead of the current flow, the sequence would be:

  Environment env;
  if (inherit-env) {
    env = platform.GetEnvironment();
    for (var : unset-env-vars)
      env.erase(var);
  }
  for (kv : env-vars)
    env[kv.first] = kv.second;

I'm not insisting on anything, I just want to see which flow would be least surprising.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76470/new/

https://reviews.llvm.org/D76470