[Lldb-commits] [PATCH] D76314: [lldb-vscode] stop read loop after termination

[Pavel Labath via Phabricator via lldb-commits]

labath accepted this revision.
labath marked an inline comment as done.
labath added inline comments.


================
Comment at: lldb/test/API/tools/lldb-vscode/launch/TestVSCode_launch.py:55-56
+        # Wait until the underlying lldb-vscode process dies.
+        # We need to do this because the popen.wait function in python2.7
+        # doesn't have a timeout argument.
+        for _ in range(10):
----------------
I'll add this to my list of reasons for dropping python2 support. :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76314/new/

https://reviews.llvm.org/D76314