[Lldb-commits] [PATCH] D74636: [lldb-vscode] Add inheritEnvironment option

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Mar 19 18:40:03 PDT 2020


clayborg added inline comments.


================
Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:1414
+    auto kv = llvm::StringRef(name_and_value).split("=");
+    env.Set(kv.first.str().c_str(), kv.second.str().c_str(), true);
+  }
----------------
We want to have a function in SBEnvironment that takes the "name=value" format:
```
env.SetEntry("FOO=bar");
```

We don't want people to have to split this themselves.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74636/new/

https://reviews.llvm.org/D74636





More information about the lldb-commits mailing list