[Lldb-commits] [PATCH] D76407: [lldb/testsuite] Remove "healthy process" test from TestProcessCrashInfo.py

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Mar 19 09:46:02 PDT 2020


jingham added a comment.

This test just seems wrong to me.  We can pretend that processes that haven't crashed don't have crash_info, and manually suppress the output in lldb if the stop state isn't a crash.  But it seems useful to ask "what are the crash_info bits in flight right now" even if you haven't crashed.  So that doesn't seem right to me.  Or you have to acknowledge that you have no way of knowing whether there is crash info data hanging around, in which case any test that depends on there being none is an invalid test.  I'd delete this whole test, since it seems to me like it will only ever succeed by accident.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76407/new/

https://reviews.llvm.org/D76407





More information about the lldb-commits mailing list