[Lldb-commits] [lldb] 127b9d9 - [lldb/testsuite] Apply @skipIfDarwinEmbedded to part of TestHWBreakMultiThread

Fred Riss via lldb-commits lldb-commits at lists.llvm.org
Wed Mar 18 20:54:25 PDT 2020


Author: Fred Riss
Date: 2020-03-18T20:52:28-07:00
New Revision: 127b9d9d774dcc593cfd50eccde307dbe96097a2

URL: https://github.com/llvm/llvm-project/commit/127b9d9d774dcc593cfd50eccde307dbe96097a2
DIFF: https://github.com/llvm/llvm-project/commit/127b9d9d774dcc593cfd50eccde307dbe96097a2.diff

LOG: [lldb/testsuite] Apply @skipIfDarwinEmbedded to part of TestHWBreakMultiThread

The comment in the test wrongfully claimed that we support hardware
breakpoints on darwin for arm64, but we never did.

Added: 
    

Modified: 
    lldb/test/API/functionalities/breakpoint/hardware_breakpoints/hardware_breakpoint_on_multiple_threads/TestHWBreakMultiThread.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/functionalities/breakpoint/hardware_breakpoints/hardware_breakpoint_on_multiple_threads/TestHWBreakMultiThread.py b/lldb/test/API/functionalities/breakpoint/hardware_breakpoints/hardware_breakpoint_on_multiple_threads/TestHWBreakMultiThread.py
index f778b8e39e72..a4a1d9effbe1 100644
--- a/lldb/test/API/functionalities/breakpoint/hardware_breakpoints/hardware_breakpoint_on_multiple_threads/TestHWBreakMultiThread.py
+++ b/lldb/test/API/functionalities/breakpoint/hardware_breakpoints/hardware_breakpoint_on_multiple_threads/TestHWBreakMultiThread.py
@@ -32,19 +32,21 @@ def test_hw_break_set_disable_multi_thread_linux(self):
         self.setTearDownCleanup()
         self.break_multi_thread('disable', False) # llvm.org/PR44659
 
-    # LLDB on darwin supports hardware breakpoints for arm, aarch64, x86_64 and
-    # i386 architectures.
+    # LLDB on darwin supports hardware breakpoints for x86_64 and i386
+    # architectures.
     @skipUnlessDarwin
     @skipIfOutOfTreeDebugserver
+    @skipIfDarwinEmbedded
     def test_hw_break_set_delete_multi_thread_macos(self):
         self.build()
         self.setTearDownCleanup()
         self.break_multi_thread('delete')
 
-    # LLDB on darwin supports hardware breakpoints for arm, aarch64, x86_64 and
-    # i386 architectures.
+    # LLDB on darwin supports hardware breakpoints for x86_64 and i386
+    # architectures.
     @skipUnlessDarwin
     @skipIfOutOfTreeDebugserver
+    @skipIfDarwinEmbedded
     def test_hw_break_set_disable_multi_thread_macos(self):
         self.build()
         self.setTearDownCleanup()


        


More information about the lldb-commits mailing list