[Lldb-commits] [PATCH] D76261: [lldb/PlatformMacOSX] Be more robust in computing the SDK path with xcrun

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Mar 17 13:30:36 PDT 2020


JDevlieghere added inline comments.


================
Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:1362
+  case SDKType::AppleTVSimulator:
     return version >= llvm::VersionTuple(8);
+  default:
----------------
aprantl wrote:
> The corresponding watchOS and tvOS numbers for iOS 8 should be lower, right? If you are in doubt, just pick the current ones.
tvOS = iOS, but yes watchOS should be `6`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76261/new/

https://reviews.llvm.org/D76261





More information about the lldb-commits mailing list