[Lldb-commits] [lldb] 332edcc - [lldb] Remove unimplemented StackFrame::BehavesLikeZerothFrame

Tatyana Krasnukha via lldb-commits lldb-commits at lists.llvm.org
Mon Mar 16 06:20:31 PDT 2020


Author: Tatyana Krasnukha
Date: 2020-03-16T16:20:12+03:00
New Revision: 332edcc6bd1dc1fd8fc33a0fb2f215a996d967fa

URL: https://github.com/llvm/llvm-project/commit/332edcc6bd1dc1fd8fc33a0fb2f215a996d967fa
DIFF: https://github.com/llvm/llvm-project/commit/332edcc6bd1dc1fd8fc33a0fb2f215a996d967fa.diff

LOG: [lldb] Remove unimplemented StackFrame::BehavesLikeZerothFrame

Commit [1] added a declaration of function-member
StackFrame::BehavesLikeZerothFrame but hasn't added an implementation
for the function. This commit removes this declation, because the
function is not used anywhere.

[1] 31e6dbe1c6a6 Fix PC adjustment in StackFrame::GetSymbolContext

Differential Revision: https://reviews.llvm.org/D75979

Patch by Anton Kolesov <Anton.Kolesov at synopsys.com>

Added: 
    

Modified: 
    lldb/include/lldb/Target/StackFrame.h

Removed: 
    


################################################################################
diff  --git a/lldb/include/lldb/Target/StackFrame.h b/lldb/include/lldb/Target/StackFrame.h
index c21916be44ae..667428e7d749 100644
--- a/lldb/include/lldb/Target/StackFrame.h
+++ b/lldb/include/lldb/Target/StackFrame.h
@@ -367,12 +367,6 @@ class StackFrame : public ExecutionContextScope,
   /// may have limited support for inspecting variables.
   bool IsArtificial() const;
 
-  /// Query whether this frame behaves like the zeroth frame, in the sense
-  /// that its pc value might not immediately follow a call (and thus might
-  /// be the first address of its function).  True for actual frame zero as
-  /// well as any other frame with the same trait.
-  bool BehavesLikeZerothFrame() const;
-
   /// Query this frame to find what frame it is in this Thread's
   /// StackFrameList.
   ///
@@ -517,6 +511,11 @@ class StackFrame : public ExecutionContextScope,
   bool m_cfa_is_valid; // Does this frame have a CFA?  Different from CFA ==
                        // LLDB_INVALID_ADDRESS
   Kind m_stack_frame_kind;
+
+  // Whether this frame behaves like the zeroth frame, in the sense
+  // that its pc value might not immediately follow a call (and thus might
+  // be the first address of its function). True for actual frame zero as
+  // well as any other frame with the same trait.
   bool m_behaves_like_zeroth_frame;
   lldb::VariableListSP m_variable_list_sp;
   ValueObjectList m_variable_list_value_objects; // Value objects for each


        


More information about the lldb-commits mailing list