[Lldb-commits] [PATCH] D76163: [lldb/Reproducers] Decode run-length encoding in GDB replay server.

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere created this revision.
JDevlieghere added reviewers: labath, jasonmolenda.
Herald added a subscriber: abidh.
JDevlieghere updated this revision to Diff 250305.
JDevlieghere added a comment.

Share RLE-decoding logic.


The GDB replay server sanity-checks that every packet it receives matches what it expects from the serialized packet log. This mechanism tripped for `TestReproducerAttach.py` on Linux, because one of the packets (`jModulesInfo`) uses run-length encoding. The replay server was comparing the expanded incoming packet with the unexpanded packet in the log. As a result, it claimed to have received an unexpected packet, which caused the test to fail.

This patch addresses that issue by expanding the run-length encoding before comparing the packets.


https://reviews.llvm.org/D76163

Files:
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.h
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationReplayServer.cpp
  lldb/test/API/functionalities/reproducers/attach/TestReproducerAttach.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D76163.250305.patch
Type: text/x-patch
Size: 6089 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200313/9c594ba9/attachment-0001.bin>