[Lldb-commits] [PATCH] D76080: Adjust error_msg handling for expect_expr in lldbtest.py

[Shafik Yaghmour via Phabricator via lldb-commits]

shafik added a comment.

In D76080#1920483 <https://reviews.llvm.org/D76080#1920483>, @teemperor wrote:

> - All of the asserts should print a useful error when failing (i.e., one that allows us to directly write a fix). You could do assertIn which is clearer than `find(...)` and automatically gives an error message that is useful. For the assertTrue just print the unexpected result in the assert message as the old code did.


Using `assertIn` makes sense.

We are using `assertIn` in a few places and what we are looking for in those is not very helpful for guidance.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76080/new/

https://reviews.llvm.org/D76080