[Lldb-commits] [PATCH] D76009: [lldb/Target] Initialize new targets environment variables from target.env-vars

[Pavel Labath via Phabricator via lldb-commits]

labath removed a reviewer: labath.
labath added a comment.
This revision now requires review to proceed.

Actually, hang on.

> One existing test had to be modified, because the initialization of
>  the environment properties now take place at the time the target is
>  created, not at the first use of the environment (usually launch
>  time).

Does this mean that the target-local value of the `target.inherit-env` setting no longer has any effect? Currently I can set it after creating a target (but before launching) to stop the process inheriting the default environment:

  (lldb) file /usr/bin/env
  Current executable set to '/usr/bin/env' (x86_64).
  (lldb) set set target.inherit-env false
  (lldb) pr la
  Process 26684 launched: '/usr/bin/env' (x86_64)
  Process 26684 exited with status = 0 (0x00000000) 

I take it that after this, that will no longer be possible? It would still be possible to do that by setting the global value of the setting before creating a target, but the target-local setting would be useless (?)

I'm not really sure how these settings are supposed to work, but this does not seem ideal to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76009/new/

https://reviews.llvm.org/D76009