[Lldb-commits] [PATCH] D74636: [lldb-vscode] Add inheritEnvironment option

Wed Mar 11 15:20:04 PDT 2020

clayborg added a comment.

In D74636#1916356 <https://reviews.llvm.org/D74636#1916356>, @labath wrote:

> There's a `target.inherit-env` setting in lldb (which I believe also works correctly for remote launches). Could you use that instead of reimplementing the feature in vscode?

The real question is if we want launching to fail when the user tries to enable this for remote targets? If we don't care if it fails, then we can use "target.inherit-env", but I kind of like that it does fail as it clearly conveys to the user that their environment won't be passed along instead of just ignoring the request. Thoughts?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74636/new/

https://reviews.llvm.org/D74636