[Lldb-commits] [PATCH] D75784: Avoid including Module.h from ExternalASTSource.h

[Aaron Ballman via Phabricator via lldb-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

Aside from minor nits, this seems reasonable to me, LG!



================
Comment at: clang/include/clang/StaticAnalyzer/Frontend/CheckerRegistry.h:16
 #include "llvm/ADT/StringRef.h"
+#include "llvm/ADT/SetVector.h"
 #include <cstddef>
----------------
Please sort the includes.


================
Comment at: clang/lib/AST/ASTContext.cpp:1619
 void ASTContext::addedLocalImportDecl(ImportDecl *Import) {
-  assert(!Import->NextLocalImport && "Import declaration already in the chain");
+  assert(!Import->getNextLocalImport() && "Import declaration already in the chain");
   assert(!Import->isFromASTFile() && "Non-local import declaration");
----------------
80-col limit


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75784/new/

https://reviews.llvm.org/D75784