[Lldb-commits] [PATCH] D75880: [NFC} Move ThreadPlans stacks into their own class, store it in Process by TID

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Mar 10 17:33:25 PDT 2020


jingham updated this revision to Diff 249525.
jingham added a comment.

Fix some clang-format nits.  I didn't change:

condition1 && condition2

  && condition3

to

condition1 && condition2 &&

  condition3

as it suggests.  We use that all over the place in lldb, and I much prefer it.  It makes it clear that you are looking at a continuation of a logical expression, which scanning to the end of the line to find the && is much harder to see.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75880/new/

https://reviews.llvm.org/D75880

Files:
  lldb/include/lldb/Target/Process.h
  lldb/include/lldb/Target/Thread.h
  lldb/include/lldb/Target/ThreadPlan.h
  lldb/include/lldb/Target/ThreadPlanStack.h
  lldb/source/Target/CMakeLists.txt
  lldb/source/Target/Process.cpp
  lldb/source/Target/Thread.cpp
  lldb/source/Target/ThreadList.cpp
  lldb/source/Target/ThreadPlan.cpp
  lldb/source/Target/ThreadPlanStack.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D75880.249525.patch
Type: text/x-patch
Size: 47268 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200311/95153ee3/attachment-0001.bin>


More information about the lldb-commits mailing list