[Lldb-commits] [PATCH] D75715: Switch TypeSystemClang over to CreateDeserialized() (NFC)

[Shafik Yaghmour via Phabricator via lldb-commits]

shafik added inline comments.


================
Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:1265
+  CXXRecordDecl *decl = CXXRecordDecl::CreateDeserialized(ast, 0);
+  decl->setTagKind((TagDecl::TagKind)kind);
+  decl->setDeclContext(decl_ctx);
----------------
`static_cast<TagDecl::TagKind>(kind)`


================
Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:1448
+  CXXRecordDecl *template_cxx_decl = CXXRecordDecl::CreateDeserialized(ast, 0);
+  template_cxx_decl->setTagKind((TagDecl::TagKind)kind);
+  // What decl context do we use here? TU? The actual decl context?
----------------
`static_cast<TagDecl::TagKind>(kind)`


================
Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:1966
+  func_decl->setType(ClangUtil::GetQualType(function_clang_type));
+  func_decl->setStorageClass((clang::StorageClass)storage);
+  func_decl->setInlineSpecified(is_inline);
----------------
`static_cast<StorageClass>(storage)`


================
Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:2028
+  decl->setType(ClangUtil::GetQualType(param_type));
+  decl->setStorageClass((clang::StorageClass)storage);
   SetOwningModule(decl, owning_module);
----------------
`static_cast<StorageClass>(storage)`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75715/new/

https://reviews.llvm.org/D75715