[Lldb-commits] [PATCH] D75864: Add a decorator option to skip tests based on a default setting

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added a comment.

LGTM but let's give Pavel another chance to take a look.



================
Comment at: lldb/test/API/sanity/TestSettingSkipping.py:28
+  def testNotExisting(self):
+    self.assertTrue(True, "This test should run!")
+
----------------
aprantl wrote:
> JDevlieghere wrote:
> > This won't trip if the tests doesn't run. If you make the assert trip and XFAIL the test it should catch it. 
> I'm not sure how that would work. Can you post an example? I want to test the skipIf decorator — how would I XFAIL it?
Yeah I think it has the same problem, skipping takes priority over XFAIL, so it wouldn't matter. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75864/new/

https://reviews.llvm.org/D75864