[Lldb-commits] [PATCH] D75761: Fix to get the AST we generate for function templates to be closer to what clang generates and expects

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

(This looks fine to me.)

In D75761#1913585 <https://reviews.llvm.org/D75761#1913585>, @shafik wrote:

> I was planning on looking into removing the template parameters from the names altogether for lldb but we would still need to do this on the lldb side to support older compilers. I have to try this and see how much it breaks.


This is a issue that has come up multiple times now. The presence of template parameters makes it very hard to use accelerator tables. I think it would be great if we could get rid of them.



================
Comment at: lldb/test/API/lang/cpp/template-function/main.cpp:1
 template<typename T>
 int foo(T t1) {
----------------
shafik wrote:
> labath wrote:
> > Do we have a test for the spaceship operator?
> We currently don't support C++2a but when we do we should add a test.
How is this lack of support "implemented"? Would it make sense to test that we do something reasonable (e.g. ignore it) if we do happen to run into it?

Given that the new version of this patch doesn't treat the spaceship operator specially, I don't think it needs to/should be a part of this patch, but it is something to think about...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75761/new/

https://reviews.llvm.org/D75761