[Lldb-commits] [PATCH] D75880: [NFC} Move ThreadPlans stacks into their own class, store it in Process by TID

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Mar 9 16:12:35 PDT 2020


jingham created this revision.
jingham added reviewers: friss, clayborg, labath.
Herald added subscribers: lldb-commits, mgorny.
Herald added a project: LLDB.
jingham added parent revisions: D75711: [NFC] Have ThreadPlans hold onto the Process & TID, rather than the Thread, D75720: Make ThreadPlanTracer use {Process,TID} rather than Thread to find it's underlying thread....

This is the third in the series of patches that move the ThreadPlan stacks out of the Threads and lets the process manage them instead.  The first two are:

https://reviews.llvm.org/D75720
https://reviews.llvm.org/D75711

This patch just moves the three thread plan stacks - current, discarded and completed - out of ThreadPlan and into the ThreadPlanStack class.  This is a nice cleanup on its own as it gets all the thread plan manipulation logic out of Thread.  Then the ThreadPlanStacks move out of Thread to Process where they are managed in a map ordered by TID.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D75880

Files:
  lldb/include/lldb/Target/Process.h
  lldb/include/lldb/Target/Thread.h
  lldb/include/lldb/Target/ThreadPlan.h
  lldb/include/lldb/Target/ThreadPlanStack.h
  lldb/source/Target/CMakeLists.txt
  lldb/source/Target/Process.cpp
  lldb/source/Target/Thread.cpp
  lldb/source/Target/ThreadList.cpp
  lldb/source/Target/ThreadPlan.cpp
  lldb/source/Target/ThreadPlanStack.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D75880.249234.patch
Type: text/x-patch
Size: 47333 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200309/7b500504/attachment-0001.bin>


More information about the lldb-commits mailing list