[Lldb-commits] [PATCH] D75711: [NFC] Have ThreadPlans hold onto the Process & TID, rather than the Thread

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Mar 9 13:30:50 PDT 2020


labath added a comment.

> Everything that holds onto its state using an ExecutionContextRef already holds onto the m_tid as the real entity, and the Thread is only a cache (see ExecutionContextRef::GetThreadSP).

I'm sorry I missed that part. (I saw the ThreadWP, but didn't look further into how it is used).

I'm going to respond in more detail tomorrow, but for now I am just wanted to let you know that my main concern about this has been addressed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75711/new/

https://reviews.llvm.org/D75711





More information about the lldb-commits mailing list