[Lldb-commits] [PATCH] D75696: Correctly detect iOS simulator processes.

[Jason Molenda via Phabricator via lldb-commits]

jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.

Overall looks fine, Fred's comment is correct, nb you want to test it with `#if TARGET_OS_OSX == 1`, it's always defined either to 0 or 1.



================
Comment at: lldb/test/API/functionalities/gdb_remote_client/TestWasm.py:35
-        if packet == "qProcessInfo":
-            return self.qProcessInfo()
         if packet[0:13] == "qRegisterInfo":
----------------
TestWasm.pys response to qProcessInfo is different than the default response you added to gdbclientutils.py; it should override the qProcessInfo method to call its own version.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75696/new/

https://reviews.llvm.org/D75696