[Lldb-commits] [lldb] eecef3a - [lldb][test] Enable fix-its for the test case that expects them enabled

Tatyana Krasnukha via lldb-commits lldb-commits at lists.llvm.org
Wed Mar 4 23:31:31 PST 2020


Author: Tatyana Krasnukha
Date: 2020-03-05T10:31:07+03:00
New Revision: eecef3af2ca8b27f4070be41c73bff989a096f9b

URL: https://github.com/llvm/llvm-project/commit/eecef3af2ca8b27f4070be41c73bff989a096f9b
DIFF: https://github.com/llvm/llvm-project/commit/eecef3af2ca8b27f4070be41c73bff989a096f9b.diff

LOG: [lldb][test] Enable fix-its for the test case that expects them enabled

Fix-its were intentionally disabled by TestBase.setUp so that incorrect expressions in tests
don't pass just because Clang thinks it has a fix-it.

Added: 
    

Modified: 
    lldb/test/API/commands/expression/fixits/TestFixIts.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/commands/expression/fixits/TestFixIts.py b/lldb/test/API/commands/expression/fixits/TestFixIts.py
index 75fe43ec7fe1..7aca1c5aa863 100644
--- a/lldb/test/API/commands/expression/fixits/TestFixIts.py
+++ b/lldb/test/API/commands/expression/fixits/TestFixIts.py
@@ -29,6 +29,10 @@ def test_with_target(self):
 
     def test_with_dummy_target(self):
         """Test calling expressions in the dummy target with errors that can be fixed by the FixIts."""
+
+        # Enable fix-its as they were intentionally disabled by TestBase.setUp.
+        self.runCmd("settings set target.auto-apply-fixits true")
+
         ret_val = lldb.SBCommandReturnObject()
         result = self.dbg.GetCommandInterpreter().HandleCommand("expression ((1 << 16) - 1))", ret_val)
         self.assertEqual(result, lldb.eReturnStatusSuccessFinishResult, "The expression was successful.")


        


More information about the lldb-commits mailing list