[Lldb-commits] [PATCH] D75418: tab completion for process signal

Tue Mar 3 02:12:38 PST 2020

labath added subscribers: jingham, labath.
labath added a comment.

In D75418#1902266 <https://reviews.llvm.org/D75418#1902266>, @MrHate wrote:

> In order to process completion successfully whenever we've got a valid process, I will update the current execution context both in `m_interpreter` and the current command object.
>  But what I am worried about is whether a new issue would be caused due to updating the current execution context.

This worries me too. I don't really understand how this works, but it seems rather odd that this command should need to do this. There's plenty of other commands that operate on the current process and they don't call `UpdateExecutionContext`. Maybe @jingham knows what is going on here?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75418/new/

https://reviews.llvm.org/D75418