[Lldb-commits] [PATCH] D75418: tab completion for process signal

gydeng via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Mar 2 21:22:47 PST 2020


MrHate added a comment.

Thanks for pointing out my misunderstanding on the Unix signals, and fetching the list of valid signals from backend is always a better way indeed.
However, getting the current process from the current context `m_exe_ctx` which is got from `m_interpreter` will cause an issue that the completion won't be triggered before executing some process commands.
This is similar to `frame variable` cause these two commands both work on the base of the current context from `m_interpreter`.
In order to process completion successfully whenever we've got a valid process, I will update the current execution context both in `m_interpreter` and the current command object.
But what I am worried about is whether a new issue would be caused due to updating the current execution context.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75418/new/

https://reviews.llvm.org/D75418





More information about the lldb-commits mailing list