[Lldb-commits] [PATCH] D74759: Treat RangeDataVector as an augmented BST

[Unnar Freyr Erlendsson via Phabricator via lldb-commits]

unnar added a comment.

Sure, removed tests from this patch. They are now at D75180 <https://reviews.llvm.org/D75180>



================
Comment at: lldb/unittests/Utility/RangeMapTest.cpp:22
 
+const std::vector<uint32_t> FindEntryIndexes(uint32_t address,
+                                             RangeDataVectorT map) {
----------------
labath wrote:
> returning a const value from a function is fairly useless. All it does is make the caller jump through some hoops if he really wants to modify it.
Noted.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74759/new/

https://reviews.llvm.org/D74759