[Lldb-commits] [PATCH] D73969: [LLDB] Let DataExtractor deal with two-byte addresses

Tue Feb 25 07:10:02 PST 2020

aykevl added a comment.

In D73969#1860696 <https://reviews.llvm.org/D73969#1860696>, @labath wrote:

> I agree only one of those two places should be enough. My idea was to make the constructors delegate to one another (if necessary by creating a private uber-constructor that everybody can delegate to). Then we could have only one assert.
>
> But if that's hard for some reason, your proposal seems fine too.

Honestly I don't feel very comfortable changing the constructors. I'm not very experienced with C++ and I'm afraid I mess something up. I could remove them from all constructors, reducing the number of asserts from 7 to 3?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73969/new/

https://reviews.llvm.org/D73969