[Lldb-commits] [PATCH] D75031: [lldb] Fix that a crashing test is marked as unsupported when it prints UNSUPPORTED before crashing

Raphael Isemann via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Feb 24 23:47:53 PST 2020


This revision was automatically updated to reflect the committed changes.
Closed by commit rG55d4b0d7dd70: [lldb] Fix that a crashing test is marked as unsupported when it prints… (authored by teemperor).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75031/new/

https://reviews.llvm.org/D75031

Files:
  lldb/test/API/lldbtest.py


Index: lldb/test/API/lldbtest.py
===================================================================
--- lldb/test/API/lldbtest.py
+++ lldb/test/API/lldbtest.py
@@ -114,14 +114,12 @@
             return lit.Test.TIMEOUT, output
 
         if exitCode:
-            # Match FAIL but not XFAIL.
-            for line in out.splitlines() + err.splitlines():
-                if line.startswith('FAIL:'):
-                    return lit.Test.FAIL, output
-
             if 'XPASS:' in out or 'XPASS:' in err:
                 return lit.Test.XPASS, output
 
+            # Otherwise this is just a failure.
+            return lit.Test.FAIL, output
+
         has_unsupported_tests = 'UNSUPPORTED:' in out or 'UNSUPPORTED:' in err
         has_passing_tests = 'PASS:' in out or 'PASS:' in err
         if has_unsupported_tests and not has_passing_tests:


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D75031.246372.patch
Type: text/x-patch
Size: 850 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200225/f0d84ad9/attachment.bin>


More information about the lldb-commits mailing list