[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

Mon Feb 24 05:37:40 PST 2020

labath added a comment.

Yes, I believe this matches the behavior we were talking about.

I could make a bunch of comments on the implementation and the test, but I'm not sure if we're at that stage yet...

================
Comment at: lldb/source/Core/SearchFilter.cpp:712
+  // the list of CU's or support files, that's enough.
+  // TODO(kwk): Is that enough?
+
----------------
I'm not sure -- it'd be good to check that we still honor the module (aka --shlib) restriction.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74136/new/

https://reviews.llvm.org/D74136