[Lldb-commits] [PATCH] D73067: [lldb/CMake] Auto-generate the Initialize and Terminate calls for plugin

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

In D73067#1884970 <https://reviews.llvm.org/D73067#1884970>, @krytarowski wrote:

> Autogeneration of the code puts extra burden on us for tracking what is defined where and for repackaging LLDB with custom build rules (we need plain Makefile in the distribution). I presume the same problem is for gn users, for FreeBSD etc.


LLVM has a policy to not consider downstream issues when making changes, so you won't achieve much from that angle (you can check out the current camel case thread on llvm-dev to see how deeply some feel about this policy). And even though we ourselves had to do some build system gymnastics to merge this change, I do think this change does make sense for llvm/lldb.

However, ignoring all downstream considerations, I am still not a fan of code generation, and if you have a idea how to achieve something similar without it, I would be very happy to hear it out.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73067/new/

https://reviews.llvm.org/D73067