[Lldb-commits] [lldb] a6370d5 - [lldb][test] - Update basic-elf.yaml to fix build bot.

Georgii Rymar via lldb-commits lldb-commits at lists.llvm.org
Sat Feb 22 05:09:55 PST 2020


Author: Georgii Rymar
Date: 2020-02-22T16:09:24+03:00
New Revision: a6370d5798313e99d37fb85db5d78f1141506864

URL: https://github.com/llvm/llvm-project/commit/a6370d5798313e99d37fb85db5d78f1141506864
DIFF: https://github.com/llvm/llvm-project/commit/a6370d5798313e99d37fb85db5d78f1141506864.diff

LOG: [lldb][test] - Update basic-elf.yaml to fix build bot.

D74764 (https://reviews.llvm.org/rG31f2ad9c368d47721508cbd0d120d626f9041715)
changed the behavior of the yaml2obj. Now it assigns virtual addresses
for allocatable sections.

SymbolFile/Breakpad/symtab.test started to fail after this change:
(http://lab.llvm.org:8011/builders/lldb-x86_64-debian/builds/5520/steps/test/logs/stdio)

Command Output (stderr):
--
/home/worker/lldb-x86_64-debian/lldb-x86_64-debian/llvm-project/lldb/test/Shell/SymbolFile/Breakpad/symtab.test:6:10: error: CHECK: expected string not found in input
# CHECK: Symtab, file = {{.*}}symtab.out, num_symbols = 5:
         ^
<stdin>:15:1: note: scanning from here
Symtab, file = /home/worker/lldb-x86_64-debian/lldb-x86_64-debian/build/tools/lldb/test/SymbolFile/Breakpad/Output/symtab.out, num_symbols = 6:
^
<stdin>:15:99: note: possible intended match here
Symtab, file = /home/worker/lldb-x86_64-debian/lldb-x86_64-debian/build/tools/lldb/test/SymbolFile/Breakpad/Output/symtab.out, num_symbols = 6:

For now I've updated the basic-elf.yaml so that now it produce the same layout as before D74764.
Breakpad/symtab.test should be updated it seems.

Added: 
    

Modified: 
    lldb/test/Shell/SymbolFile/Breakpad/Inputs/basic-elf.yaml

Removed: 
    


################################################################################
diff  --git a/lldb/test/Shell/SymbolFile/Breakpad/Inputs/basic-elf.yaml b/lldb/test/Shell/SymbolFile/Breakpad/Inputs/basic-elf.yaml
index 905dc25c3a67..d4b8684778b4 100644
--- a/lldb/test/Shell/SymbolFile/Breakpad/Inputs/basic-elf.yaml
+++ b/lldb/test/Shell/SymbolFile/Breakpad/Inputs/basic-elf.yaml
@@ -20,6 +20,14 @@ Sections:
     Address:         0x00000000004000B0
     AddressAlign:    0x0000000000000010
     Size:            0x42
+  - Name:            .dynsym
+    Type:            SHT_PROGBITS
+    Flags:           [ SHF_ALLOC ]
+    Address:         0x0
+  - Name:            .dynstr
+    Type:            SHT_STRTAB
+    Flags:           [ SHF_ALLOC ]
+    Address:         0x0
 Symbols:         
 DynamicSymbols:  
 ProgramHeaders:


        


More information about the lldb-commits mailing list