[Lldb-commits] [PATCH] D74957: [lldb] Disable auto fix-its when evaluating expressions in the test suite

[Raphael Isemann via Phabricator via lldb-commits]

teemperor marked 3 inline comments as done.
teemperor added inline comments.


================
Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:2404
+        # Disable fix-its that tests don't pass by accident.
+        options.SetAutoApplyFixIts(True)
+
----------------
shafik wrote:
> Should this be `False` or is the comment incorrect?
True (heh), I changed that to false as some tests were failing in very unexpected ways on my system with this patch and I wanted to double check that it's not the fixits. Forgot to change this line back afterwards :(


================
Comment at: lldb/test/API/lang/cpp/operators/main.cpp:174
   //% self.expect("expr c.operatornew()", endstr=" 14\n")
-  //% self.expect("expr (new C)->custom_new", endstr=" true\n")
+  //% self.expect("expr (new struct C)->custom_new", endstr=" true\n")
   //% self.expect("expr (new struct C[1])->custom_new", endstr=" true\n")
----------------
shafik wrote:
> This is puzzling, I don't know why we need the `struct` for I don't see why an elborated type specifier is required here.
I remember I was confused about this when I wrote the line below as Clang forced me to add the 'struct' (as apparently there Clang wasn't smart enough for the automatic fixit). I didn't investigate back then as I already had enough on my plate but with some luck that's an easy fix (maybe we get some language option wrong?).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74957/new/

https://reviews.llvm.org/D74957