[Lldb-commits] [PATCH] D74957: [lldb] Disable auto fix-its when evaluating expressions in the test suite

[Shafik Yaghmour via Phabricator via lldb-commits]

shafik accepted this revision.
shafik added a comment.
This revision is now accepted and ready to land.

LGTM outside of my comments



================
Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:2404
+        # Disable fix-its that tests don't pass by accident.
+        options.SetAutoApplyFixIts(True)
+
----------------
Should this be `False` or is the comment incorrect?


================
Comment at: lldb/test/API/lang/cpp/operators/main.cpp:174
   //% self.expect("expr c.operatornew()", endstr=" 14\n")
-  //% self.expect("expr (new C)->custom_new", endstr=" true\n")
+  //% self.expect("expr (new struct C)->custom_new", endstr=" true\n")
   //% self.expect("expr (new struct C[1])->custom_new", endstr=" true\n")
----------------
This is puzzling, I don't know why we need the `struct` for I don't see why an elborated type specifier is required here.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74957/new/

https://reviews.llvm.org/D74957