[Lldb-commits] [PATCH] D74917: [lldb/bindings] Fail configuration when a required dependency is not met.
Matt Davis via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu Feb 20 16:28:28 PST 2020
mattd added a comment.
In D74917#1885590 <https://reviews.llvm.org/D74917#1885590>, @JDevlieghere wrote:
> It should never be possible for `LLDB_ENABLE_PYTHON` to be true but `SWIG_FOUND` to be false. The modules `FindPythonInterpAndLibs.cmake` and `FindLuaAndSwig.cmake` should fail early when SWIG isn't found.
Thanks for taking a look. Would you be okay with making the status `message()` in `FindPythonInterpAndLibs.cmake` and `FindLuaAndSwig.cmake` fatal, that way the dependency error is clearer?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74917/new/
https://reviews.llvm.org/D74917
More information about the lldb-commits
mailing list