[Lldb-commits] [PATCH] D74657: [lldb/Plugins] Add ability to fetch crash information on crashed processes

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere accepted this revision.
JDevlieghere added a comment.

A few small nits inline, but this LGTM if Pavel is on board.



================
Comment at: lldb/source/Commands/CommandObjectProcess.cpp:1260
+    if (command.GetArgumentCount()) {
+      result.AppendError("`process status` takes no arguments");
+      result.SetStatus(eReturnStatusFailed);
----------------
Please use single quotes like we do for other command objects. 


================
Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:1541
+
+    ConstString section_name("__crash_info");
+    SectionSP crash_info = sections->FindSectionByName(section_name);
----------------
You can move this out of the loop


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74657/new/

https://reviews.llvm.org/D74657