[Lldb-commits] [lldb] 6990eaf - [lldb/Test] Skip VSCode test on embedded Darwin

[Jonas Devlieghere via lldb-commits]

On Wed, Feb 19, 2020 at 5:57 PM Davide Italiano <ditaliano at apple.com> wrote:

>
>
> On Feb 19, 2020, at 17:52, Frédéric Riss <friss at apple.com> wrote:
>
>
>
> On Feb 19, 2020, at 5:44 PM, Davide Italiano via lldb-commits <
> lldb-commits at lists.llvm.org> wrote:
>
>
>
> On Feb 19, 2020, at 17:34, Jonas Devlieghere via lldb-commits <
> lldb-commits at lists.llvm.org> wrote:
>
>
> Author: Jonas Devlieghere
> Date: 2020-02-19T17:34:01-08:00
> New Revision: 6990eaf1fe00e9736fbfbcae160e18c5edbcd1d4
>
> URL:
> https://github.com/llvm/llvm-project/commit/6990eaf1fe00e9736fbfbcae160e18c5edbcd1d4
> DIFF:
> https://github.com/llvm/llvm-project/commit/6990eaf1fe00e9736fbfbcae160e18c5edbcd1d4.diff
>
> LOG: [lldb/Test] Skip VSCode test on embedded Darwin
>
> These tests are not configured to run on the device.
>
>
>
> I’ve never seen these failing. Did you?
>
>
> Yes, I did. All of them fail for me and 2 of them hang.
>
> `@skipIfDarwinEmbedded` obviously works for us, but I’m wondering if
> `@skipIfRemote` would not be a better/more generic fix?
>
>
> @skipIfRemote is obviously a better fix.
>

I can update the decorators.


> It would be nice if all the vscode tests could be categorized and we could
> put a single annotation on them, so that in case somebody adds another
> test, we don’t have to do this decorator gymnastics.
>

Agreed, but unfortunately that's not how dotest works. Now that the tests
actually live under test/API we might be able to change the way we discover
them and reuse lit's capabilities with lit.local.cfg files.


>
> —
> Davide
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200219/5de75244/attachment.html>