[Lldb-commits] [PATCH] D74839: [lldb] Remove license headers from all test source files

Raphael Isemann via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Feb 19 08:05:21 PST 2020


teemperor created this revision.
teemperor added a reviewer: LLDB.
Herald added subscribers: lldb-commits, JDevlieghere, arphaman, aprantl, emaste.
Herald added a reviewer: espindola.
Herald added a project: LLDB.

Around a third of our test sources have LLVM license headers. This patch removes those headers from all test
sources and also fixes any tests that depended on the length of the license header.

The reasons for this are:

- A few tests verify line numbers and will start failing if the number of lines in the LLVM license header changes. Once I landed my patch for valid SourceLocations in debug info we will probably have even more tests that verify line numbers.
- No other LLVM project is putting license headers in its test files to my knowledge.
- They make the test sources much more verbose than they have to be. Several tests have longer license headers than the actual test source.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D74839

Files:
  lldb/test/API/android/platform/main.cpp
  lldb/test/API/api/check_public_api_headers/main.cpp.template
  lldb/test/API/benchmarks/expression/main.cpp
  lldb/test/API/commands/add-dsym/uuid/main.cpp.template
  lldb/test/API/commands/apropos/with-process/main.cpp
  lldb/test/API/commands/command/nested_alias/main.cpp
  lldb/test/API/commands/command/script/main.cpp
  lldb/test/API/commands/disassemble/basic/main.cpp
  lldb/test/API/commands/expression/ir-interpreter-phi-nodes/main.cpp
  lldb/test/API/commands/expression/persistent_types/main.c
  lldb/test/API/commands/expression/persistent_variables/main.c
  lldb/test/API/commands/expression/radar_8638051/main.c
  lldb/test/API/commands/expression/radar_9531204/main.c
  lldb/test/API/commands/expression/radar_9673664/main.c
  lldb/test/API/commands/expression/save_jit_objects/main.c
  lldb/test/API/commands/frame/recognizer/main.m
  lldb/test/API/commands/frame/var-scope/main.c
  lldb/test/API/commands/log/basic/main.cpp
  lldb/test/API/commands/register/register/intel_xtended_registers/main.cpp
  lldb/test/API/commands/register/register/intel_xtended_registers/mpx_bound_violation/main.cpp
  lldb/test/API/commands/register/register/register_command/a.cpp
  lldb/test/API/commands/register/register/register_command/main.cpp
  lldb/test/API/commands/settings/main.cpp
  lldb/test/API/commands/target/basic/a.c
  lldb/test/API/commands/target/basic/b.c
  lldb/test/API/commands/target/basic/c.c
  lldb/test/API/commands/target/basic/globals.c
  lldb/test/API/commands/target/create-deps/a.cpp
  lldb/test/API/commands/target/create-deps/main.cpp
  lldb/test/API/commands/watchpoints/hello_watchlocation/main.cpp
  lldb/test/API/commands/watchpoints/hello_watchpoint/main.c
  lldb/test/API/commands/watchpoints/multi_watchpoint_slots/main.c
  lldb/test/API/commands/watchpoints/multiple_hits/main.cpp
  lldb/test/API/commands/watchpoints/multiple_threads/main.cpp
  lldb/test/API/commands/watchpoints/watchpoint_commands/command/main.cpp
  lldb/test/API/commands/watchpoints/watchpoint_commands/condition/main.cpp
  lldb/test/API/commands/watchpoints/watchpoint_commands/main.c
  lldb/test/API/commands/watchpoints/watchpoint_on_vectors/main.c
  lldb/test/API/commands/watchpoints/watchpoint_set_command/main.cpp
  lldb/test/API/commands/watchpoints/watchpoint_size/main.c
  lldb/test/API/functionalities/archives/a.c
  lldb/test/API/functionalities/archives/b.c
  lldb/test/API/functionalities/archives/main.c
  lldb/test/API/functionalities/asan/main.c
  lldb/test/API/functionalities/breakpoint/breakpoint_by_line_and_column/TestBreakpointByLineAndColumn.py
  lldb/test/API/functionalities/breakpoint/breakpoint_by_line_and_column/main.c
  lldb/test/API/functionalities/breakpoint/breakpoint_command/main.c
  lldb/test/API/functionalities/breakpoint/breakpoint_conditions/main.c
  lldb/test/API/functionalities/breakpoint/breakpoint_hit_count/main.cpp
  lldb/test/API/functionalities/breakpoint/breakpoint_ids/main.cpp
  lldb/test/API/functionalities/breakpoint/breakpoint_ignore_count/main.c
  lldb/test/API/functionalities/breakpoint/breakpoint_names/main.c
  lldb/test/API/functionalities/breakpoint/breakpoint_set_restart/main.cpp
  lldb/test/API/functionalities/breakpoint/comp_dir_symlink/main.cpp
  lldb/test/API/functionalities/breakpoint/consecutive_breakpoints/main.cpp
  lldb/test/API/functionalities/breakpoint/cpp/main.cpp
  lldb/test/API/functionalities/breakpoint/hardware_breakpoints/hardware_breakpoint_on_multiple_threads/main.cpp
  lldb/test/API/functionalities/breakpoint/serialize/main.c
  lldb/test/API/functionalities/conditional_break/main.c
  lldb/test/API/functionalities/darwin_log/basic/main.c
  lldb/test/API/functionalities/darwin_log/filter/exact_match/activity-chain/main.c
  lldb/test/API/functionalities/darwin_log/filter/exact_match/activity/main.c
  lldb/test/API/functionalities/darwin_log/filter/exact_match/category/main.c
  lldb/test/API/functionalities/darwin_log/filter/exact_match/message/main.c
  lldb/test/API/functionalities/darwin_log/filter/exact_match/subsystem/main.c
  lldb/test/API/functionalities/darwin_log/filter/regex/activity-chain/main.c
  lldb/test/API/functionalities/darwin_log/filter/regex/activity/main.c
  lldb/test/API/functionalities/darwin_log/filter/regex/category/main.c
  lldb/test/API/functionalities/darwin_log/filter/regex/message/main.c
  lldb/test/API/functionalities/darwin_log/filter/regex/subsystem/main.c
  lldb/test/API/functionalities/darwin_log/format/main.c
  lldb/test/API/functionalities/darwin_log/source/debug/main.c
  lldb/test/API/functionalities/darwin_log/source/info/main.c
  lldb/test/API/functionalities/data-formatter/boolreference/main.mm
  lldb/test/API/functionalities/data-formatter/compactvectors/main.cpp
  lldb/test/API/functionalities/data-formatter/data-formatter-advanced/main.cpp
  lldb/test/API/functionalities/data-formatter/data-formatter-categories/main.cpp
  lldb/test/API/functionalities/data-formatter/data-formatter-cpp/main.cpp
  lldb/test/API/functionalities/data-formatter/data-formatter-globals/main.cpp
  lldb/test/API/functionalities/data-formatter/data-formatter-named-summaries/main.cpp
  lldb/test/API/functionalities/data-formatter/data-formatter-objc/cmtime/main.m
  lldb/test/API/functionalities/data-formatter/data-formatter-objc/main.m
  lldb/test/API/functionalities/data-formatter/data-formatter-objc/nsindexpath/main.m
  lldb/test/API/functionalities/data-formatter/data-formatter-objc/nsstring/main.m
  lldb/test/API/functionalities/data-formatter/data-formatter-proper-plurals/main.m
  lldb/test/API/functionalities/data-formatter/data-formatter-ptr-to-array/main.cpp
  lldb/test/API/functionalities/data-formatter/data-formatter-script/main.cpp
  lldb/test/API/functionalities/data-formatter/data-formatter-smart-array/main.cpp
  lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/atomic/main.cpp
  lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/function/TestLibCxxFunction.py
  lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/function/main.cpp
  lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/initializerlist/main.cpp
  lldb/test/API/functionalities/data-formatter/data-formatter-synth/main.cpp
  lldb/test/API/functionalities/data-formatter/dump_dynamic/main.cpp
  lldb/test/API/functionalities/data-formatter/frameformat_smallstruct/main.cpp
  lldb/test/API/functionalities/data-formatter/hexcaps/main.cpp
  lldb/test/API/functionalities/data-formatter/language_category_updates/main.cpp
  lldb/test/API/functionalities/data-formatter/nsarraysynth/main.m
  lldb/test/API/functionalities/data-formatter/nsdictionarysynth/main.m
  lldb/test/API/functionalities/data-formatter/nssetsynth/main.m
  lldb/test/API/functionalities/data-formatter/ostypeformatting/main.mm
  lldb/test/API/functionalities/data-formatter/parray/main.cpp
  lldb/test/API/functionalities/data-formatter/poarray/main.mm
  lldb/test/API/functionalities/data-formatter/ptr_ref_typedef/main.cpp
  lldb/test/API/functionalities/data-formatter/pyobjsynthprovider/main.cpp
  lldb/test/API/functionalities/data-formatter/setvaluefromcstring/main.m
  lldb/test/API/functionalities/data-formatter/stringprinter/main.cpp
  lldb/test/API/functionalities/data-formatter/summary-string-onfail/main.cpp
  lldb/test/API/functionalities/data-formatter/synthupdate/main.m
  lldb/test/API/functionalities/data-formatter/typedef_array/main.cpp
  lldb/test/API/functionalities/data-formatter/user-format-vs-summary/main.cpp
  lldb/test/API/functionalities/data-formatter/var-in-aggregate-misuse/main.cpp
  lldb/test/API/functionalities/data-formatter/vector-types/main.cpp
  lldb/test/API/functionalities/dead-strip/main.c
  lldb/test/API/functionalities/inferior-assert/main.c
  lldb/test/API/functionalities/inferior-changed/main.c
  lldb/test/API/functionalities/inferior-changed/main2.c
  lldb/test/API/functionalities/inferior-crashing/main.c
  lldb/test/API/functionalities/load_unload/a.cpp
  lldb/test/API/functionalities/load_unload/b.cpp
  lldb/test/API/functionalities/load_unload/c.cpp
  lldb/test/API/functionalities/load_unload/d.cpp
  lldb/test/API/functionalities/load_unload/hidden/d.cpp
  lldb/test/API/functionalities/load_unload/main.cpp
  lldb/test/API/functionalities/load_using_paths/hidden/d.cpp
  lldb/test/API/functionalities/load_using_paths/main.cpp
  lldb/test/API/functionalities/longjmp/main.c
  lldb/test/API/functionalities/memory/cache/main.cpp
  lldb/test/API/functionalities/memory/find/main.cpp
  lldb/test/API/functionalities/memory/read/main.cpp
  lldb/test/API/functionalities/non-overlapping-index-variable-i/main.cpp
  lldb/test/API/functionalities/plugins/command_plugin/plugin.cpp.template
  lldb/test/API/functionalities/postmortem/elf-core/gcore/main.cpp
  lldb/test/API/functionalities/postmortem/elf-core/thread_crash/main.cpp
  lldb/test/API/functionalities/ptr_refs/main.c
  lldb/test/API/functionalities/recursion/main.cpp
  lldb/test/API/functionalities/tail_call_frames/ambiguous_tail_call_seq1/main.cpp
  lldb/test/API/functionalities/tail_call_frames/ambiguous_tail_call_seq2/main.cpp
  lldb/test/API/functionalities/tail_call_frames/disambiguate_call_site/main.cpp
  lldb/test/API/functionalities/tail_call_frames/disambiguate_paths_to_common_sink/main.cpp
  lldb/test/API/functionalities/tail_call_frames/disambiguate_tail_call_seq/main.cpp
  lldb/test/API/functionalities/tail_call_frames/inlining_and_tail_calls/main.cpp
  lldb/test/API/functionalities/tail_call_frames/sbapi_support/main.cpp
  lldb/test/API/functionalities/tail_call_frames/thread_step_out_message/main.cpp
  lldb/test/API/functionalities/tail_call_frames/thread_step_out_or_return/main.cpp
  lldb/test/API/functionalities/tail_call_frames/unambiguous_sequence/main.cpp
  lldb/test/API/functionalities/thread/break_after_join/main.cpp
  lldb/test/API/functionalities/thread/concurrent_events/main.cpp
  lldb/test/API/functionalities/thread/crash_during_step/main.cpp
  lldb/test/API/functionalities/thread/create_during_step/main.cpp
  lldb/test/API/functionalities/thread/exit_during_break/main.cpp
  lldb/test/API/functionalities/thread/exit_during_step/main.cpp
  lldb/test/API/functionalities/thread/jump/main.cpp
  lldb/test/API/functionalities/thread/jump/other.cpp
  lldb/test/API/functionalities/thread/multi_break/main.cpp
  lldb/test/API/functionalities/thread/state/main.cpp
  lldb/test/API/functionalities/thread/step_out/main.cpp
  lldb/test/API/functionalities/thread/thread_exit/main.cpp
  lldb/test/API/functionalities/tsan/basic/main.c
  lldb/test/API/functionalities/tsan/cpp_global_location/main.cpp
  lldb/test/API/functionalities/tsan/global_location/main.c
  lldb/test/API/functionalities/tsan/multiple/main.m
  lldb/test/API/functionalities/tsan/thread_leak/main.c
  lldb/test/API/functionalities/tsan/thread_numbers/main.c
  lldb/test/API/functionalities/type_completion/main.cpp
  lldb/test/API/functionalities/type_lookup/main.mm
  lldb/test/API/functionalities/unwind/standard/hand_written/divmod.cpp
  lldb/test/API/functionalities/unwind/standard/hand_written/fprintf.cpp
  lldb/test/API/functionalities/unwind/standard/hand_written/new_delete.cpp
  lldb/test/API/functionalities/value_md5_crash/main.cpp
  lldb/test/API/issue_verification/inline_rerun_inferior.cpp
  lldb/test/API/lang/c/array_types/main.c
  lldb/test/API/lang/c/bitfields/main.c
  lldb/test/API/lang/c/enum_types/main.c
  lldb/test/API/lang/c/function_types/main.c
  lldb/test/API/lang/c/global_variables/a.c
  lldb/test/API/lang/c/global_variables/main.c
  lldb/test/API/lang/c/set_values/main.c
  lldb/test/API/lang/c/stepping/main.c
  lldb/test/API/lang/c/strings/main.c
  lldb/test/API/lang/c/struct_types/main.c
  lldb/test/API/lang/c/tls_globals/a.c
  lldb/test/API/lang/c/tls_globals/main.c
  lldb/test/API/lang/c/typedef/main.c
  lldb/test/API/lang/cpp/auto/main.cpp
  lldb/test/API/lang/cpp/bool/main.cpp
  lldb/test/API/lang/cpp/char1632_t/main.cpp
  lldb/test/API/lang/cpp/class-template-parameter-pack/main.cpp
  lldb/test/API/lang/cpp/class_static/main.cpp
  lldb/test/API/lang/cpp/class_types/main.cpp
  lldb/test/API/lang/cpp/const_this/main.cpp
  lldb/test/API/lang/cpp/diamond/main.cpp
  lldb/test/API/lang/cpp/dynamic-value/sbvalue-cast.cpp
  lldb/test/API/lang/cpp/enum_types/main.cpp
  lldb/test/API/lang/cpp/extern_c/main.cpp
  lldb/test/API/lang/cpp/frame-var-anon-unions/main.cpp
  lldb/test/API/lang/cpp/function-template-parameter-pack/main.cpp
  lldb/test/API/lang/cpp/global_variables/main.cpp
  lldb/test/API/lang/cpp/lambdas/main.cpp
  lldb/test/API/lang/cpp/llvm-style/main.cpp
  lldb/test/API/lang/cpp/namespace/main.cpp
  lldb/test/API/lang/cpp/namespace/ns.cpp
  lldb/test/API/lang/cpp/namespace/ns.h
  lldb/test/API/lang/cpp/namespace/ns2.cpp
  lldb/test/API/lang/cpp/namespace/ns3.cpp
  lldb/test/API/lang/cpp/namespace_conflicts/main.cpp
  lldb/test/API/lang/cpp/namespace_definitions/a.cpp
  lldb/test/API/lang/cpp/namespace_definitions/b.cpp
  lldb/test/API/lang/cpp/namespace_definitions/foo.h
  lldb/test/API/lang/cpp/namespace_definitions/main.cpp
  lldb/test/API/lang/cpp/printf/main.cpp
  lldb/test/API/lang/cpp/signed_types/main.cpp
  lldb/test/API/lang/cpp/static_members/main.cpp
  lldb/test/API/lang/cpp/static_methods/main.cpp
  lldb/test/API/lang/cpp/stl/main.cpp
  lldb/test/API/lang/cpp/symbols/main.cpp
  lldb/test/API/lang/cpp/template-function/main.cpp
  lldb/test/API/lang/cpp/template/main.cpp
  lldb/test/API/lang/cpp/this/main.cpp
  lldb/test/API/lang/cpp/type_lookup/main.cpp
  lldb/test/API/lang/cpp/unicode-literals/main.cpp
  lldb/test/API/lang/cpp/unique-types/main.cpp
  lldb/test/API/lang/cpp/unsigned_types/main.cpp
  lldb/test/API/lang/cpp/wchar_t/main.cpp
  lldb/test/API/lang/objc/bitfield_ivars/main.m
  lldb/test/API/lang/objc/exceptions/TestObjCExceptions.py
  lldb/test/API/lang/objc/exceptions/main.mm
  lldb/test/API/lang/objc/print-obj/blocked.m
  lldb/test/API/lang/objc/ptr_refs/main.m
  lldb/test/API/lang/objc/self/main.m
  lldb/test/API/lang/objc/variadic_methods/main.m
  lldb/test/API/linux/builtin_trap/main.cpp
  lldb/test/API/linux/thread/create_during_instruction_step/main.cpp
  lldb/test/API/macosx/duplicate-archive-members/a.c
  lldb/test/API/macosx/duplicate-archive-members/main.c
  lldb/test/API/macosx/duplicate-archive-members/sub1/a.c
  lldb/test/API/macosx/nslog/main.m
  lldb/test/API/macosx/order/main.c
  lldb/test/API/python_api/class_members/main.mm
  lldb/test/API/python_api/event/main.c
  lldb/test/API/python_api/exprpath_synthetic/main.mm
  lldb/test/API/python_api/frame/get-variables/main.c
  lldb/test/API/python_api/frame/main.c
  lldb/test/API/python_api/function_symbol/main.c
  lldb/test/API/python_api/lldbutil/frame/main.c
  lldb/test/API/python_api/lldbutil/iter/main.cpp
  lldb/test/API/python_api/lldbutil/process/main.cpp
  lldb/test/API/python_api/objc_type/main.m
  lldb/test/API/python_api/process/main.cpp
  lldb/test/API/python_api/sbdata/main.cpp
  (28 more files...)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74839.245409.patch
Type: text/x-patch
Size: 199215 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200219/c8b97147/attachment-0001.bin>


More information about the lldb-commits mailing list