[Lldb-commits] [lldb] 1b2deb9 - [lldb] Remove Windows X-fail for TestCPPAuto and TestStepTarget

Raphael Isemann via lldb-commits lldb-commits at lists.llvm.org
Wed Feb 19 06:05:53 PST 2020


Author: Raphael Isemann
Date: 2020-02-19T15:05:36+01:00
New Revision: 1b2deb9ae00f6fa1e47ec7059d777fb36a1df1d1

URL: https://github.com/llvm/llvm-project/commit/1b2deb9ae00f6fa1e47ec7059d777fb36a1df1d1
DIFF: https://github.com/llvm/llvm-project/commit/1b2deb9ae00f6fa1e47ec7059d777fb36a1df1d1.diff

LOG: [lldb] Remove Windows X-fail for TestCPPAuto and TestStepTarget

TestCPPAuto was only failing on windows due to the std::string
copying (which was not related at all to 'auto' functionality).

TestStepTarget is now also passing but that seems more that we
now have by accident the right behavior in Windows. I'll remove
the x-fail just to make the bot green again.

Added: 
    

Modified: 
    lldb/test/API/lang/c/step-target/TestStepTarget.py
    lldb/test/API/lang/cpp/auto/TestCPPAuto.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/lang/c/step-target/TestStepTarget.py b/lldb/test/API/lang/c/step-target/TestStepTarget.py
index 7665b2f73b6a..0b97f400be46 100644
--- a/lldb/test/API/lang/c/step-target/TestStepTarget.py
+++ b/lldb/test/API/lang/c/step-target/TestStepTarget.py
@@ -73,7 +73,6 @@ def test_with_end_line_bad_name(self):
         self.assertEqual(frame.line_entry.line, self.end_line,
             "Stepped to the block end.")
 
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr32343")
     def test_with_end_line_deeper(self):
         """Test stepping over vrs. hitting breakpoints & subsequent stepping in various forms."""
 

diff  --git a/lldb/test/API/lang/cpp/auto/TestCPPAuto.py b/lldb/test/API/lang/cpp/auto/TestCPPAuto.py
index c8a33e6cf658..b0e7ff73e98d 100644
--- a/lldb/test/API/lang/cpp/auto/TestCPPAuto.py
+++ b/lldb/test/API/lang/cpp/auto/TestCPPAuto.py
@@ -14,7 +14,6 @@ class CPPAutoTestCase(TestBase):
     @expectedFailureAll(
         compiler="gcc",
         bugnumber="GCC generates incomplete debug info")
-    @expectedFailureAll(oslist=['windows'], bugnumber="llvm.org/pr26339")
     @expectedFailureNetBSD
     def test_with_run_command(self):
         """Test that auto types work in the expression parser"""


        


More information about the lldb-commits mailing list