[Lldb-commits] [PATCH] D74780: [lldb/Plugin] Reject WASM and Hexagon in DynamicLoaderStatic

Paolo Severini via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Feb 18 12:45:23 PST 2020


paolosev accepted this revision.
paolosev added a comment.
This revision is now accepted and ready to land.

In D74780#1881297 <https://reviews.llvm.org/D74780#1881297>, @JDevlieghere wrote:

> Sorting the plugins so the static loader is initialized before the WASM loader should exercise this code path.


Yes, test //functionalities/gdb_remote_client/TestWasm.py// fails when the order of plugins is sorted.

LGTM. Could you also sort the initialization of DynamicLoaderStatic and DynamicLoaderWasmDYLD in lldb\tools\lldb-test\SystemInitializerTest.cpp and lldb\source\API\SystemInitializerFull.cpp?


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74780/new/

https://reviews.llvm.org/D74780





More information about the lldb-commits mailing list