[Lldb-commits] [PATCH] D74556: [lldb] Don't call CopyForBreakpoint from a Breakpoint's constructor

Tue Feb 18 04:24:18 PST 2020

The test was passing unexpectedly, I already removed XFAIL decorator.

-----Original Message-----
From: Raphael “Teemperor” Isemann <teemperor at gmail.com> 
Sent: Tuesday, February 18, 2020 3:20 PM
To: reviews+D74556+public+411e87b2a9392f49 at reviews.llvm.org
Cc: Tatyana Krasnukha <tatyana at synopsys.com>; Jonas Devlieghere <jonas at devlieghere.com>; jingham at apple.com; lldb-commits at lists.llvm.org; Liburd1994 at outlook.com; sanimir at subpath.org; chirag at raincode.com
Subject: Re: [PATCH] D74556: [lldb] Don't call CopyForBreakpoint from a Breakpoint's constructor

I assume this is causing the test to fail on Windows? https://urldefense.proofpoint.com/v2/url?u=http-3A__lab.llvm.org-3A8011_builders_lldb-2Dx64-2Dwindows-2Dninja_builds_13896&d=DwIFAg&c=DPL6_X_6JkXFx7AXWqB0tg&r=8NZfjV_ZLY_S7gZyQMq8mj7tiN4vlymPiSt0Wl0jegw&m=QVHIvP2O76mhlXu3NHpC60dV9plTxqLsbwE_fgLAJZk&s=jk0NPJjYvMlZIFBH2uPt1fo6zA543ZKEeBlU9108M_M&e= 

> On 18. Feb 2020, at 12:26, Tatyana Krasnukha via Phabricator <reviews at reviews.llvm.org> wrote:
> 
> tatyana-krasnukha closed this revision.
> tatyana-krasnukha added a comment.
> 
> Closed by commit 185ef697ef5c <https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_rG185ef697ef5c60d7a5c801925e6abdad52226c2b&d=DwIFAg&c=DPL6_X_6JkXFx7AXWqB0tg&r=8NZfjV_ZLY_S7gZyQMq8mj7tiN4vlymPiSt0Wl0jegw&m=QVHIvP2O76mhlXu3NHpC60dV9plTxqLsbwE_fgLAJZk&s=60fetWjgmI89GvtLbDkwSsqTFy5j8zgTG7rvDByg_LY&e= >
> 
> 
> Repository:
>  rLLDB LLDB
> 
> CHANGES SINCE LAST ACTION
>  https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D74556_new_&d=DwIFAg&c=DPL6_X_6JkXFx7AXWqB0tg&r=8NZfjV_ZLY_S7gZyQMq8mj7tiN4vlymPiSt0Wl0jegw&m=QVHIvP2O76mhlXu3NHpC60dV9plTxqLsbwE_fgLAJZk&s=wjRYSdktS4jTXskJlmyc_cPVY0vx5rODphb2Q-TWpRI&e= 
> 
> https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D74556&d=DwIFAg&c=DPL6_X_6JkXFx7AXWqB0tg&r=8NZfjV_ZLY_S7gZyQMq8mj7tiN4vlymPiSt0Wl0jegw&m=QVHIvP2O76mhlXu3NHpC60dV9plTxqLsbwE_fgLAJZk&s=eSiNRVypMo66Enyp_4OaR4YA1Bp_jSqCp92hhqUo3zI&e= 
> 
> 
> 