[Lldb-commits] [lldb] 0ba247b - [lldb] Remove the mutable specifier from DataExtractor's member

[Pavel Labath via lldb-commits]

Author: Pavel Labath
Date: 2020-02-18T10:26:43+01:00
New Revision: 0ba247bc21f8aed000e649882e6e360fb90e81e5

URL: https://github.com/llvm/llvm-project/commit/0ba247bc21f8aed000e649882e6e360fb90e81e5
DIFF: https://github.com/llvm/llvm-project/commit/0ba247bc21f8aed000e649882e6e360fb90e81e5.diff

LOG: [lldb] Remove the mutable specifier from DataExtractor's member

Having m_data_sp mutable sounds like a very bad idea. Fortunately,
nothing relies on this possibility.

Added: 
    

Modified: 
    lldb/include/lldb/Utility/DataExtractor.h

Removed: 
    


################################################################################
diff  --git a/lldb/include/lldb/Utility/DataExtractor.h b/lldb/include/lldb/Utility/DataExtractor.h
index 7157b89e86da..7f09b7114a8d 100644
--- a/lldb/include/lldb/Utility/DataExtractor.h
+++ b/lldb/include/lldb/Utility/DataExtractor.h
@@ -1005,8 +1005,8 @@ class DataExtractor {
       m_byte_order;     ///< The byte order of the data we are extracting from.
   uint32_t m_addr_size; ///< The address size to use when extracting pointers or
                         /// addresses
-  mutable lldb::DataBufferSP m_data_sp; ///< The shared pointer to data that can
-                                        /// be shared among multiple instances
+  /// The shared pointer to data that can be shared among multiple instances
+  lldb::DataBufferSP m_data_sp;
   const uint32_t m_target_byte_size;
 };