[Lldb-commits] [PATCH] D74217: Add target.xml support for qXfer request.

Jaroslav Sevcik via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Feb 17 22:53:41 PST 2020


jarin added inline comments.


================
Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:2814
+
+    if (reg_info->invalidate_regs && reg_info->invalidate_regs[0]) {
+      response.PutCString("invalidate_regnums=\"");
----------------
I know this is copy&paste from qRegisterInfo, but should not this be `if (reg_info->invalidate_regs && reg_info->invalidate_regs[0] != LLDB_INVALID_REGNUM)`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74217/new/

https://reviews.llvm.org/D74217





More information about the lldb-commits mailing list