[Lldb-commits] [PATCH] D74217: Add target.xml support for qXfer request.

Mon Feb 17 22:34:32 PST 2020

jarin added inline comments.

================
Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:465
+      response.PutChar(',');
+    response.Printf("%" PRIx32, *reg_num);
+  }
----------------
I think this is not correct: target.xml expects this to be [decimal](https://github.com/llvm-mirror/lldb/blob/d01083a850f577b85501a0902b52fd0930de72c7/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp#L4417). (This is different from qRegisterInfo, which expects [hex](https://github.com/llvm-mirror/lldb/blob/d01083a850f577b85501a0902b52fd0930de72c7/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp#L579).)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74217/new/

https://reviews.llvm.org/D74217