[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

Mon Feb 17 15:58:21 PST 2020

JDevlieghere added a comment.

In D72751#1879806 <https://reviews.llvm.org/D72751#1879806>, @paolosev wrote:

> @JDevlieghere added inline comments:
>
> > lldb/source/API/SystemInitializerFull.cpp 244
> >  What's the rationale here? Plugins shouldn't rely on the order in which they are initialized. This breaks when the initializers are auto generated. Can we remove this dependency?
>
> This was discussed in one of the comments above. If DynamicLoaderStatic preceeds DynamicLoaderWasmDYLD then it is recognized as a valid loader for a triple like "wasm32-unknown-unknown-wasm" because the Triple::OS is llvm::Triple::UnknownOS.
>  There is an explicit check for UnknownOS in DynamicLoaderStatic::CreateInstance().
>  Should `DynamicLoaderStatic::CreateInstance` behave differently just when the architecture is wasm32, as a workaround?

I think it depends on whether the `DynamicLoaderStatic` should be a fallback. If it doesn't make sense then yes, I think we should reject that triple there.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72751/new/

https://reviews.llvm.org/D72751