[Lldb-commits] [PATCH] D74637: Separate DIERef vs. user_id_t: m_function_scope_qualified_name_map

Mon Feb 17 05:21:43 PST 2020

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

In D74637#1878748 <https://reviews.llvm.org/D74637#1878748>, @jankratochvil wrote:

> In D74637#1878720 <https://reviews.llvm.org/D74637#1878720>, @labath wrote:
>
> > Suppose these patches are accepted (let's call them tentatively accepted). What would be the next steps?
>
>
> I find this patch as a NFC cleanup to the codebase - to satisfy a new premise `user_id_t` is used as little as possible and thus only for external interfaces which must not deal with MainCU in any way.

Ok, I think I can go with that. I wanted to get a feel for where your going  (something mid-level plan between this patch, and the "big DWZ plan") to see where this is going, but I think we can accept this just on the basis that it is a revert of D63322 <https://reviews.llvm.org/D63322>, which turned out to be a dud. And the changes are not that big so it's not a big deal if we need to modify this.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74637/new/

https://reviews.llvm.org/D74637