[Lldb-commits] [PATCH] D74637: Separate DIERef vs. user_id_t: m_function_scope_qualified_name_map

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

In D74637#1878704 <https://reviews.llvm.org/D74637#1878704>, @jankratochvil wrote:

> > I did it because it was
> >  b) more memory-efficient.
>
> Why? Both `DIERef` and `user_id_t` sizeof is 8.


Ah, sorry, I misremembered that (and confused DIERef with DWARFDIE). I think what happened is that at the time I was writing that patch, I was planning to increase the size of DIERef. But in the end, that did not materialize (we chose to drop the somewhat redundant cu_offset field instead).

> 
> 
>> Maybe you could give a rough outline of where are you going with this.
> 
> I am trying to reduce `user_id_t` usage as much as possible.  And then to add MainCU to `user_id_t` (but no longer to `DIERef`). As construction of `user_id_t` with MainCU needs additional information no longer contained in `DIERef` it will need some additional parameter in the caller chain like I did in D73206 <https://reviews.llvm.org/D73206>.

Ok, this part makes sense. It's hard for me to evaluate the rest, as the code your linking to still assumes that the MainCU is stored in the DIERef, which you now say you want to change. Suppose these patches are accepted (let's call them tentatively accepted). What would be the next steps?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74637/new/

https://reviews.llvm.org/D74637