[Lldb-commits] [PATCH] D74690: Separate DIERef vs. user_id_t: GetForwardDeclClangTypeToDie()

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

The thing I said on the other patch about DIERef vs user_id_t still applies. Let's continue the discussion there...



================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DIERef.h:37
 
+  DIERef() {}
+
----------------
I'd very much like to avoid a default-constructed DIERef -- in the previous refactoring, I've deleted that concept and tried to use Optional<DIERef> in contexts, where the object can be empty.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74690/new/

https://reviews.llvm.org/D74690