[Lldb-commits] [PATCH] D74657: [lldb/Target] Add process crash-info command

Mon Feb 17 00:56:12 PST 2020

labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.

All of this code you're adding to Process.cpp is extremely specific to one platform's notion of "crash info". This should be factored out so that macos-specific details live inside some macos class. (In the current setup, it's probably easiest to put it in PlatformDarwin, or some subclass thereof).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74657/new/

https://reviews.llvm.org/D74657