[Lldb-commits] [PATCH] D74585: Don't prefix error message from process launch with "process launch failed:" boilerplate in Target::Launch

Thu Feb 13 23:56:03 PST 2020

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

I think this is fine.

I added a "gdb client" test for an attach failure error message a while back, so I was curious if the same thing can be done for launches -- it can and 65e843c9 <https://reviews.llvm.org/rG65e843c9e0b91d5ac156130f61b378bad2e8e2fd> has the result. I think that patch shows that we really should remove the prefix, since the equivalent "attach" error does not have any additional prefixes.

PS: Don't forget to update the new test before committing this. :)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74585/new/

https://reviews.llvm.org/D74585