[Lldb-commits] [PATCH] D74557: [lldb] Make BreakpointResolver hold weak_ptr instead of raw pointer to breakpoint

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

I wonder if it wouldn't be better to assert in GetBreakpoint.  Except when you are making the resolver, you should never have a breakpoint resolver without a valid breakpoint.  And there's no point in calling GetBreakpoint when you know you haven't set it yet.  You assert after most of the calls to GetBreakpoint, but not all.  Of the ones you don't, I think most of them should be.

Were there any places you found where it was legit to ask for the Breakpoint for a resolver and not have one?

Other than that LGTM.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74557/new/

https://reviews.llvm.org/D74557