[Lldb-commits] [PATCH] D74451: [lldb/Plugins] Have one initializer per ABI plugin

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Feb 13 00:59:54 PST 2020


labath accepted this revision.
labath added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lldb/source/API/SystemInitializerFull.cpp:27-34
+LLDB_PLUGIN_DECLARE(ABIAArch64);
+LLDB_PLUGIN_DECLARE(ABIARM);
 LLDB_PLUGIN_DECLARE(ABISysV_arc);
 LLDB_PLUGIN_DECLARE(ABISysV_hexagon);
-LLDB_PLUGIN_DECLARE(ABISysV_mips);
-LLDB_PLUGIN_DECLARE(ABISysV_mips64);
-LLDB_PLUGIN_DECLARE(ABISysV_ppc);
-LLDB_PLUGIN_DECLARE(ABISysV_ppc64);
+LLDB_PLUGIN_DECLARE(ABIMips);
+LLDB_PLUGIN_DECLARE(ABIPowerPC);
 LLDB_PLUGIN_DECLARE(ABISysV_s390x);
----------------
Are you missing the equivalent changes in SystemInitializerTest ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74451/new/

https://reviews.llvm.org/D74451





More information about the lldb-commits mailing list