[Lldb-commits] [PATCH] D74255: [LLDB] Add support for AVR breakpoints

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

The whole flow here is pretty nonsensical -- the only reason we ask for the opcode is to get its size so we can put it into the Z0 packet -- however this is only needed for targets like arm, which have mutiple ISAs/opcodes, and we've already gotten complaints about sending that unconditionally.

However, if we look at this locally, if the AVR architecture has a trap opcode (maybe to implement `__builtin_debugbreak()` -- I am assuming that's what 0x98 0x95 is), then I don't see a problem with this function returning it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74255/new/

https://reviews.llvm.org/D74255