[Lldb-commits] [lldb] 477c090 - [lldb][NFC] Remove eCustomCompletion mode

[Raphael Isemann via lldb-commits]

Author: Raphael Isemann
Date: 2020-02-12T08:34:02+01:00
New Revision: 477c09043e654bc154fce6e6b013f8f91fb96f05

URL: https://github.com/llvm/llvm-project/commit/477c09043e654bc154fce6e6b013f8f91fb96f05
DIFF: https://github.com/llvm/llvm-project/commit/477c09043e654bc154fce6e6b013f8f91fb96f05.diff

LOG: [lldb][NFC] Remove eCustomCompletion mode

It's not used by anyone. Also if something implements its own
completion it could just not call the method instead of having
a parameter that makes the function a no-op.

Added: 
    

Modified: 
    lldb/source/Commands/CommandCompletions.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Commands/CommandCompletions.cpp b/lldb/source/Commands/CommandCompletions.cpp
index 2ced56f90178..0e35e0d1123f 100644
--- a/lldb/source/Commands/CommandCompletions.cpp
+++ b/lldb/source/Commands/CommandCompletions.cpp
@@ -29,7 +29,6 @@ using namespace lldb_private;
 
 CommandCompletions::CommonCompletionElement
     CommandCompletions::g_common_completions[] = {
-        {eCustomCompletion, nullptr},
         {eSourceFileCompletion, CommandCompletions::SourceFiles},
         {eDiskFileCompletion, CommandCompletions::DiskFiles},
         {eDiskDirectoryCompletion, CommandCompletions::DiskDirectories},
@@ -47,9 +46,6 @@ bool CommandCompletions::InvokeCommonCompletionCallbacks(
     CompletionRequest &request, SearchFilter *searcher) {
   bool handled = false;
 
-  if (completion_mask & eCustomCompletion)
-    return false;
-
   for (int i = 0;; i++) {
     if (g_common_completions[i].type == eNoCompletion)
       break;